docs: restructure README per README guidelines#14
Merged
Conversation
Apply the project README guidelines to @edison/shared, adapting the CLI-oriented patterns to a source-consumed library: - Lead with a dense "what is this" paragraph and a one-line tagline - Add an inline nav bar and a NOTE maturity callout (0.1.0, unpublished) - Add a committed architecture diagram (docs/architecture.svg) plus an ASCII module/build layout in a collapsible Architecture section - Use progressive disclosure with TLDR lines for Quick start, Visual regression tests, and Architecture - Tabulate package entrypoints and link modules out to src/ - Show the EnvConfig schema as an annotated example - Add Credits and a contrib.rocks contributors footer Avoids em dashes and contrastive parallelism so the AI-writing CI check passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Replace the prose paragraph with the prior four-bullet summary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Redraw the SVG and ASCII diagrams around durable concepts (two capability domains, standard-module distribution, host runtime) instead of folder names, subpaths, component lists, and specific build tooling, so the diagrams survive routine renames and refactoring. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Move both reference sections behind <details> with TLDR lines so the top-level README scan stays short. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Fixes the CI format:check failure (aligned tables, comment spacing). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Redraw docs/architecture.svg per the Edison brand guide: void-black field, electric-cyan wireframe boxes with solid corner tags (40% width, varied placement for rhythm), white Archivo-stack typography, cyan grid markers and arrows. Architecture content is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
The brand SVG near the top already conveys the architecture, so the duplicate text diagram and its section are removed (and dropped from the nav bar). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Drop the host-runtime layer (and the inbound arrow), tighten the canvas height, and update the README alt text to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures the README to follow the project's README guidelines (pitch first, progressive disclosure, TLDRs, tables, copy-pasteable commands), adapted for a source-consumed library rather than a CLI product.
What changed
•-separated nav bar.> [!NOTE]for the0.1.0, not-published-to-npm status and the "no secrets in this repo" rule.docs/architecture.svgplus a matching ASCII diagram. Both are deliberately abstract (two capability domains, standard-module distribution, host runtime) and avoid folder names, subpaths, component lists, and specific build tooling, so they survive routine renames and refactoring.<details>, each with a one-lineTLDR:.EnvConfiginterface (no live secret values).CLI-only guideline sections that do not apply to this package (install one-liner,
--help/doctor, agent quickstart, exit codes, leaderboard, API-key env vars) were dropped.Notes
scripts/check-ai-writing.tsCI check.🤖 Generated with Claude Code
https://claude.ai/code/session_01BSXhDvj3zDtbbqz8XzL7ke
Generated by Claude Code
Summary by cubic
Restructures the README to follow our guidelines with a pitch‑first layout, progressive disclosure, and copy‑paste commands. Adds a brand‑styled architecture SVG (two‑domain view, host runtime removed), clarifies config scope and the unpublished status for
@edison/shared, and removes the duplicate Architecture section and ASCII diagram.New Features
•nav (Architecture link removed).0.1.0, not published to npm, and “no secrets in this repo”.EnvConfig, peer deps note, and clear config scope.docs/architecture.svg(simplified to design‑system + client‑services; host‑runtime layer and inbound arrow removed; alt text updated).Bug Fixes
format:checkCI failure.Written for commit dbe7dbc. Summary will update on new commits.