test: add testIDs to wallet options menu for maestro selectors#6060
Open
j0ntz wants to merge 1 commit into
Open
test: add testIDs to wallet options menu for maestro selectors#6060j0ntz wants to merge 1 commit into
j0ntz wants to merge 1 commit into
Conversation
Add testID to WalletListMenuModal rows (walletListMenu_<value>) so the wallet options menu (Resync, etc.) is drivable by automated UI tests. The row labels render via UnscaledText, which does not expose matchable accessibility text, so the rows previously had no stable selector. Claude-Session: https://claude.ai/code/session_01NWSBgjqm8PkwCp8ziCrgX1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Test infrastructure only — no behavior or visual change.
Add
testID={walletListMenu_${option.value}}to theWalletListMenuModalrows so automated UI tests can drive the wallet options menu (Resync, Wallet Settings, Export Transactions, etc.). The row labels render throughUnscaledText, which does not expose matchable accessibility text, so these rows had no stable selector and could not be tapped by maestro. Surfaced while writing an iOS resync test for the eCash node fix.Asana: https://app.asana.com/0/1215088146871429/1213046875952149
Note
Low Risk
Test-only selector attributes on touchables; no logic, navigation, or visual changes.
Overview
Adds
testID={walletListMenu_${option.value}}on eachWalletListMenuModalmenu row so Maestro (and similar UI automation) can tap actions like Resync, Wallet Settings, and Export Transactions by stable id instead of label text.No user-facing or behavioral change—labels still render through
UnscaledText, which does not give matchable accessibility text for those rows.Reviewed by Cursor Bugbot for commit 05d23e6. Bugbot is set up for automated code reviews on this repo. Configure here.