Skip to content

fix(ssl): skip le renewal on alias-domain change for non-le sites #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrrobot47 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(ssl): skip le renewal on alias-domain change for non-le sites #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/helper/class-ee-site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,14 +610,22 @@ protected function update_alias_domains( $args, $assoc_args ) {
$old_certs = $client->loadDomainCertificates( $all_domains );

if ( $is_ssl ) {
// Update SSL.
EE::log( 'Updating and force renewing SSL certificate to accomodated alias domain changes.' );
try {
$this->ssl_renew( [ $this->site_data['site_url'] ], [ 'force' => true ] );
} catch ( \Exception $e ) {
EE::warning( 'Certificate could not be issued. Reverting back to original state.' );
$this->enable( [ $this->site_data['site_url'] ], [ 'refresh' => 'true' ] );
EE::error( $e->getMessage() );
// Only Let's Encrypt certs can be reissued by EE to cover the new alias-domain set.
if ( 'le' === $this->site_data['site_ssl'] ) {
// Update SSL.
EE::log( 'Updating and force renewing SSL certificate to accomodated alias domain changes.' );
try {
$this->ssl_renew( [ $this->site_data['site_url'] ], [ 'force' => true ] );
} catch ( \Exception $e ) {
EE::warning( 'Certificate could not be issued. Reverting back to original state.' );
$this->enable( [ $this->site_data['site_url'] ], [ 'refresh' => 'true' ] );
EE::error( $e->getMessage() );
}
} elseif ( 'custom' === $this->site_data['site_ssl'] ) {
EE::warning( 'Custom SSL certificate is not renewed automatically. Please ensure the certificate you provided covers the updated alias-domain set.' );
} else {
// self-signed certs are wildcard and inherited certs use the parent site's cert; no cert action needed.
EE::log( 'No SSL certificate action needed for ' . $this->site_data['site_ssl'] . ' SSL on alias domain change.' );
}
}

Expand Down
Loading