Skip to content

fix(ssl): correct misleading renewal-threshold log message#485

Open
mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/ssl-renewal-log-message
Open

fix(ssl): correct misleading renewal-threshold log message#485
mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/ssl-renewal-log-message

Conversation

@mrrobot47

Copy link
Copy Markdown
Member

Problem

During certificate renewal, Site_Letsencrypt::executeRenewal() logs:

Current certificate will expire in less than 25 days (...), renewal is required.

But the threshold that triggers this branch is 35 days$parsedCertificate->getValidTo()->format('U') - time() >= 3024000 (and 3024000s = 35 days, per the comment right above it). The "25 days" wording understates the renewal window by 10 days and misleads operators about how urgent the renewal is.

Fix

Correct the message to "less than 35 days" so it matches the 35-day threshold directly above it. Pure log-text fix — no logic or threshold change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant