Provide generic way to propagate env vars into startprefix environment#260
Merged
Neves-P merged 2 commits intoJun 24, 2026
Conversation
…ropagated into the startprefix environment
Contributor
Author
|
This PR is easily tested. As we can see, a regular env var doesn't make it into the But, if we prefix it with |
Contributor
Author
|
Ok, made it even more specific: |
Neves-P
approved these changes
Jun 24, 2026
Neves-P
left a comment
Member
There was a problem hiding this comment.
Looks good to me, and works as intended when tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a generic way with which to prefix env vars so that they are propagated into the startprefix environment: you simply set
EESSI_PROPAGATE_INTO_PREFIX_X=valto get a variableX=valdefined within your startprefix environment.This is useful for workarounds like the one that would be needed here, where we would want to set
export UCX_IB_GPU_DIRECT_RDMA=nin the UGent bot's site configuration script. The current issue is that this doesn't get propagated unless it is explicitely in the list of whitelisted variables inrun_in_compat_layer_env.sh. However, it does not make any sense to put this variable in that list, since that propagation is only needed for the UGent bot. Moreover, it means that if you ever want to propagate a variable, you always have to change therun_in_compat_layer_env.shscript first.Having a long and specific enough prefix to the name of the env var allows us to specify such environment variables in the environment outside of
startprefix, yet make therun_in_compat_layer_env.shautomatically export these inside the prefix.