feat(events): allow stomp server to handle multiple event sources#1386
feat(events): allow stomp server to handle multiple event sources#1386JamesDoingStuff wants to merge 1 commit into
Conversation
JamesDoingStuff
force-pushed
the
jg/waffle-test-posixuid
branch
from
ce30ebf to
ec4b303
Compare
There was a problem hiding this comment.
Is there a reason why the ClusterWorkflowTemplate is in the templates in events and not in examples? Is this tracked by groups or is it intentionally ignored?
There was a problem hiding this comment.
These are purely for testing event-based triggering while it's still in development and aren't meant to be examples for users to follow, so I don't intend to keep them in the repository long-term. They aren't tracked by groups but they aren't ignored either; they still appear in the template list.
| workflows.diamond.ac.uk/source: generic | ||
| workflows.diamond.ac.uk/beamline: b01-1 | ||
| spec: | ||
| enabled: true |
There was a problem hiding this comment.
would it be worth helm templating the different trigger.enabled values?
There was a problem hiding this comment.
Yeah I think I will put that in as it will mean I can test events more easily without spamming dozens of workflows. Worth noting though that the plan is to eventually have these Triggers be created by users via the graph, so these will get deleted
There was a problem hiding this comment.
Actually I've just realised that the enabled field in the triggers currently doesn't do anything - I need to implement it in the metacontroller sync hook. I'll probably do that in a separate PR as it's a little beyond the scope of this one I feel
JamesDoingStuff
force-pushed
the
jg/waffle-test-posixuid
branch
from
ec4b303 to
394261c
Compare
3 participants
AP-1158
Each new connection is stored in a connection manager object, each with its own event queue. This means that a new connection won't overwrite a previous one