feat: add authz checks to API#1539
Open
shree-iyengar-dls wants to merge 32 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tiled-token-validation #1539 +/- ##
==========================================================
+ Coverage 95.86% 95.89% +0.02%
==========================================================
Files 44 44
Lines 3292 3338 +46
==========================================================
+ Hits 3156 3201 +45
- Misses 136 137 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
reviewed
May 15, 2026
shree-iyengar-dls
changed the title
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
27a9865 to
ae58c78
Compare
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
b575c2b to
b6049c8
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
ae58c78 to
8112e4b
Compare
ZohebShaikh
reviewed
Jun 4, 2026
ZohebShaikh
left a comment
ZohebShaikh
left a comment
Contributor
There was a problem hiding this comment.
Looks Good, few comments
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
b6049c8 to
63009c0
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
8112e4b to
a4c6778
Compare
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
63009c0 to
9865265
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
a4c6778 to
4fa20de
Compare
tpoliaw
reviewed
Jun 5, 2026
| ): | ||
| task = runner.run(interface.get_task_by_id, task_id) | ||
|
|
||
| if opa and not opa.admin() and (task and fedid != task.task.metadata.get("user")): |
Contributor
There was a problem hiding this comment.
This only checks task access if OPA is configured. Do we want to restrict access based on user name when authn is enabled but authz is not?
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
9865265 to
41e28ca
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
1168a23 to
fa02ed5
Compare
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
41e28ca to
1c0d35f
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
0912158 to
6237ebc
Compare
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
1c0d35f to
494c3f6
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
6237ebc to
bcb0423
Compare
tpoliaw
changed the title
tpoliaw
force-pushed
the
tiled-token-validation
branch
from
494c3f6 to
0482d81
Compare
tpoliaw
force-pushed
the
add_depedency_injection
branch
from
bcb0423 to
55c9886
Compare
| LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class OpaClient: |
Contributor
Author
There was a problem hiding this comment.
Nit: might be helpful to have a brief comment explaining the difference between OpaClient and OpaUserClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require authz checks as part of endpoints that modify state of the blueapi deployment either by running plans or changing existing tasks.