fix: Install debugpy in container instead of adding it#1528
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 44 44
Lines 3292 3292
=======================================
Hits 3156 3156
Misses 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
reviewed
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Can a check be added here
If publish == true ..version == tagged_version &&
if publish is false version is semver compliant
So we can have some regression test for it
tpoliaw
force-pushed
the
container-version
branch
from
7631aee to
9266c8a
Compare
abbiemery
force-pushed
the
container-version
branch
from
9266c8a to
07bb68c
Compare
abbiemery
approved these changes
May 27, 2026
Contributor
Author
|
I don't understand why the version number is being mangled by the setuptools-scm. |
ZohebShaikh
approved these changes
Jun 24, 2026
Running `uv add debugpy` in the container modifies pyproject.toml and uv.lock so `git describe` reports local changes in the repo and appends a `dev0+g<commit>.d<date>` suffix to the version used for the blueapi in the container Using `uv pip install debugpy` makes it available in the environment without modifying any tracked files. This has to be run after the `uv sync` to stop it being removed again.
tpoliaw
force-pushed
the
container-version
branch
from
07bb68c to
b2a9a50
Compare
Contributor
Author
|
Have removed the test commit from this PR and moved it to #1561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
uv add debugpyin the container modifies pyproject.toml anduv.lock so
git describereports local changes in the repo and appendsa
dev0+g<commit>.d<date>suffix to the version used for the blueapi inthe container
Using
uv pip install debugpymakes it available in the environmentwithout modifying any tracked files.
This has to be run after the
uv syncto stop it being removed again.