ci(miri): skip slow miri tests#2188
Open
morrisonlevi wants to merge 2 commits into
Open
Conversation
morrisonlevi
requested review from
leoromanovsky and
typotter
and removed request for
a team
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 537b03f | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
The run-miri job partitions were taking 20-24 minutes each, dominated by 34 tests nextest flagged as SLOW (many 400-520s). None of these hang or exercise unsafe code Miri exists to check - they're slow because Miri must bytecode-interpret real TLS/HTTP client construction (rustls/ring crypto init, cert-store loading), tokio's executor park/wake machinery, large fixture-driven test loops, or regex-crate compilation/serde overhead on otherwise-trivial inputs.
morrisonlevi
force-pushed
the
levi/slow-miri
branch
from
82d63b7 to
b5da2b8
Compare
danielsn
reviewed
Jul 1, 2026
| .await; | ||
| } | ||
|
|
||
| #[cfg_attr(miri, ignore)] // tokio executor park/wake overhead is prohibitively slow under Miri |
Contributor
There was a problem hiding this comment.
could we put this behind a flag so we can have a slow nightly check that does validate them?
Contributor
Author
There was a problem hiding this comment.
I'm not opposed but I think that should be a different PR as there are already many cfg_attr(miri, ignore) attributes aside from these; git grep "cfg_attr(miri, ignore)" says 460, this PR added just 34 of them. I'm sure many of those are because of performance as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
#[cfg_attr(miri, ignore)]to 34 SLOW tests.Motivation
The run-miri job partitions were taking 20-24 minutes each, dominated by 34 tests nextest flagged as SLOW (many 400-520s). None of these hang or exercise unsafe code Miri exists to check - they're slow because Miri must bytecode-interpret real TLS/HTTP client construction (rustls/ring crypto init, cert-store loading), tokio's executor park/wake machinery, large fixture-driven test loops, or regex-crate compilation/serde overhead on otherwise-trivial inputs.
Additional Notes
I had claude sonnet 5 do all the analysis and judge the appropriate fixes, and had it leave justifications for why so we can audit that ourselves. They look reasonable to me.
How to test the change?
Same as usual, should just be faster under miri.