refactor(libdd-remote-config)!: hide Target inner properties so they are not leaked#2182
Open
hoolioh wants to merge 2 commits into
Open
refactor(libdd-remote-config)!: hide Target inner properties so they are not leaked#2182hoolioh wants to merge 2 commits into
hoolioh wants to merge 2 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: fa0a7cd | Docs | Datadog PR Page | Give us feedback! |
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
hoolioh
force-pushed
the
julio/remove-common-types-from-rc
branch
from
443c3a9 to
513ee52
Compare
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 513ee52576
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| pub use libdd_common::{tag::Tag, Endpoint}; | ||
|
|
||
| use serde::{Deserialize, Serialize}; |
There was a problem hiding this comment.
When consumers construct the public fetch::ConfigInvariants, its endpoint field still has type libdd_common::Endpoint, but this hunk removes the only libdd_remote_config::Endpoint re-export. In downstream crates that only depend on libdd-remote-config, this forces adding a direct libdd-common dependency pinned to the exact same version and can reintroduce the duplicate-crate problem this change is trying to avoid; keep re-exporting Endpoint while dropping only Tag.
Useful? React with 👍 / 👎.
bwoebi
reviewed
Jun 30, 2026
hoolioh
force-pushed
the
julio/remove-common-types-from-rc
branch
from
f09c1ad to
fa0a7cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hide internal implementation so types are not leaked to the consumers
Motivation
Avoid symol/crate duplication on downstream projects.