chore!: update protobufs to be in sync with datadog-agent by duncanpharvey · Pull Request #2180 · DataDog/libdatadog

duncanpharvey · 2026-06-29T17:53:59Z

What does this PR do?

Update protobufs to be in sync with datadog-agent
- containerDebug
- additional_metric_tags
Update DATADOG_AGENT_TAG for protobufs comparison to DataDog/datadog-agent@fdc29d4

Motivation

Out of sync protobufs with datadog-agent. Needed for #2170.

Additional Notes

How to test the change?

Weekly test to compare protobufs to main: https://github.com/DataDog/libdatadog/actions/workflows/weekly-verify-proto-files.yml
Per PR test to compare protobugs to specified commit: https://github.com/DataDog/libdatadog/actions/workflows/verify-proto-files.yml

github-actions · 2026-06-29T17:56:26Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/duncan-harvey/trace-protobuf

Summary by Rule

Rule	Base Branch	PR Branch	Change
todo	2	2	No change (0%)
unimplemented	1	1	No change (0%)
Total	3	3	No change (0%)

Annotation Counts by File

File	Base Branch	PR Branch	Change
`libdd-trace-utils/src/trace_utils.rs`	2	2	No change (0%)
`libdd-trace-utils/src/tracer_payload.rs`	1	1	No change (0%)

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	22	22	No change (0%)
`datadog-live-debugger`	4	4	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-sidecar`	45	45	No change (0%)
`libdd-common`	13	13	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	6	6	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-remote-config`	3	3	No change (0%)
`libdd-telemetry`	20	20	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	3	3	No change (0%)
`libdd-trace-stats`	1	1	No change (0%)
`libdd-trace-utils`	11	11	No change (0%)
Total	182	182	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

datadog-official · 2026-06-29T17:56:36Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 73.97% (-0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fbb6a57 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-06-29T19:01:47Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	85.13 MB	85.13 MB	+0% (+696 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.82 MB	7.82 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	96.27 MB	96.27 MB	+0% (+728 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.51 MB	10.51 MB	+0% (+24 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	25.14 MB	25.14 MB	+0% (+512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	88.04 KB	88.04 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	183.32 MB	183.33 MB	+0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	938.88 MB	939.07 MB	+.01% (+188.05 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	8.22 MB	8.22 MB	+0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	88.04 KB	88.04 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	24.30 MB	24.30 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	48.47 MB	48.47 MB	+0% (+496 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	21.79 MB	21.79 MB	+0% (+512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	89.42 KB	89.42 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	187.40 MB	187.41 MB	+0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	927.44 MB	927.62 MB	+.01% (+184.27 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.35 MB	6.35 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	89.42 KB	89.42 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	26.09 MB	26.09 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	46.11 MB	46.11 MB	+0% (+406 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	75.88 MB	75.88 MB	+0% (+632 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.70 MB	8.70 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	91.34 MB	91.34 MB	+0% (+560 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.59 MB	10.59 MB	0% (0 B) 👌

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcd399f658

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-29T19:15:00Z

+    /// containerDebug holds debug information about the container tags resolution.
+    /// @gotags: json:"container_debug,omitempty" msg:"container_debug,omitempty"
+    #[prost(message, optional, tag = "11")]
+    pub container_debug: ::core::option::Option<ContainerDebug>,


Compare container_debug before merging payloads

When callers pass V07 payloads with this field populated, coalesce_send_data() still invokes TracerPayloadCollection::merge(), which treats payloads as equal via cmp_send_data_payloads() without looking at container_debug and then appends one payload's chunks into the other while dropping its top-level fields. Two payloads with different container tag resolution errors/latencies will therefore be sent as one payload with only the retained payload's debug value, misreporting the new diagnostics for the chunks from the dropped payload; include container_debug in the merge key or avoid merging when it differs.

Useful? React with 👍 / 👎.

Fixed in f8b4091.

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b386a6fc90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-29T19:49:55Z

+    /// containerDebug holds debug information about the container tags resolution.
+    /// @gotags: json:"container_debug,omitempty" msg:"container_debug,omitempty"
+    #[prost(message, optional, tag = "11")]
+    pub container_debug: ::core::option::Option<ContainerDebug>,


Omit absent container debug from msgpack payloads

When sending V07 payloads through send_with_msgpack, every locally constructed tracer payload currently sets this field to None; because the generated serde field has no skip_serializing_if, rmp_serde::to_vec_named emits a container_debug: nil entry instead of omitting it, despite the new proto tag being omitempty. That changes the v0.7 wire map for all agentless sends even when no debug data exists, so please generate #[serde(skip_serializing_if = "Option::is_none")] for this field.

Useful? React with 👍 / 👎.

Fixed in f97eaf5.

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f97eaf5059

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-29T20:33:23Z

+    /// @gotags: json:"container_debug,omitempty" msg:"container_debug,omitempty"
+    #[prost(message, optional, tag = "11")]
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub container_debug: ::core::option::Option<ContainerDebug>,


Default omitted ContainerDebug subfields

When a Serde-encoded v0.7 payload includes container_debug but omits any of its omitempty subfields (for example a successful lookup may send only latency/buffering data and omit error), deserialization will fail because the nested ContainerDebug fields are still required. The Option here only handles the whole container_debug field being absent; please add #[serde(default)] for the ContainerDebug fields/type in the generator so Rust accepts the same partial payloads allowed by the proto/go tags.

Useful? React with 👍 / 👎.

Fixed in fbb6a57.

@codex review

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: fbb6a5753b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review

Mark a draft as ready

Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

duncanpharvey · 2026-07-01T18:49:53Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-01T18:49:57Z

View all feedbacks in Devflow UI.

2026-07-01 18:49:57 UTC ℹ️ Start processing command /merge

2026-07-01 18:50:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-07-01 19:34:53 UTC ℹ️ MergeQueue: This merge request was merged

github-actions Bot added ci-build mini-agent labels Jun 29, 2026

duncanpharvey force-pushed the duncan-harvey/trace-protobuf branch from 992baa9 to 40583a8 Compare June 29, 2026 17:56

duncanpharvey temporarily deployed to nightlies June 29, 2026 17:56 — with GitHub Actions Inactive

duncanpharvey force-pushed the duncan-harvey/trace-protobuf branch from 40583a8 to 13da553 Compare June 29, 2026 18:01

duncanpharvey deployed to nightlies June 29, 2026 18:01 — with GitHub Actions Active

duncanpharvey changed the title ~~chore: update protobufs to be in sync with datadog-agent~~ chore!: update protobufs to be in sync with datadog-agent Jun 29, 2026

update protobufs

bcd399f

duncanpharvey force-pushed the duncan-harvey/trace-protobuf branch from 13da553 to bcd399f Compare June 29, 2026 18:31

duncanpharvey marked this pull request as ready for review June 29, 2026 19:04

duncanpharvey requested review from a team as code owners June 29, 2026 19:04

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

duncanpharvey added 2 commits June 29, 2026 15:31

include container_debug TracerPayload comparison

f8b4091

apply formatting

b386a6f

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

skip serializing container_debug if none

f97eaf5

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

add #[serde(default)] to ContainerDebug fields

fbb6a57

VianneyRuhlmann approved these changes Jul 1, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Jul 1, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit b02d454 into main Jul 1, 2026
100 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the duncan-harvey/trace-protobuf branch July 1, 2026 19:34

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Jul 1, 2026

Uh oh!

Conversation

duncanpharvey commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

github-actions Bot commented Jun 29, 2026

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

datadog-official Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey commented Jul 1, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

duncanpharvey commented Jun 29, 2026 •

edited

Loading

datadog-official Bot commented Jun 29, 2026 •

edited

Loading

dd-octo-sts Bot commented Jun 29, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026 •

edited

Loading