[APMSVLS-469] chore(deps): bump libdatadog to a820699 (align bottlecap with serverless-components)#1294
Draft
lucaspimentel wants to merge 1 commit into
Draft
[APMSVLS-469] chore(deps): bump libdatadog to a820699 (align bottlecap with serverless-components)#1294lucaspimentel wants to merge 1 commit into
libdatadog to a820699 (align bottlecap with serverless-components)#1294lucaspimentel wants to merge 1 commit into
Conversation
…ents Move bottlecap's libdd-* pins from 48da0d82 to a820699, matching the libdatadog revision used by serverless-components / the Serverless Compat Layer. Also bump the serverless-components deps (dogstatsd, datadog-fips, datadog-agent-config) from 8ce37eb0 to d05932a5 (current main), which pins the same a820699 libdatadog. The two bumps are coupled: datadog-agent-config's public API exposes libdd_trace_obfuscation::ReplaceRule, so bottlecap and the config crate must resolve to a single libdatadog revision. Mixing revisions puts two incompatible ReplaceRule types in the graph and fails to compile (E0308). No production source changes. Precursor to the APMSVLS-469 error sampler, which consumes the datadog-agent-trace-sampler crate from a serverless-components base that pins a820699. 🤖
lucaspimentel
changed the title
libdatadog to a820699 (align bottlecap with serverless-components)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Aligns bottlecap's
libdatadogrevision with serverless-components / the Serverless Compat Layer, as a precursor to the APMSVLS-469 error sampler.libdd-*pins from48da0d82toa820699(e.g.libdd-trace-utilsv6 -> v8,libdd-trace-obfuscationv3 -> v4).dogstatsd,datadog-fips,datadog-agent-config) from8ce37eb0tod05932a5(current serverless-componentsmain), which pins the samea820699libdatadog.Why the two bumps are coupled:
datadog-agent-config's public API exposeslibdd_trace_obfuscation::ReplaceRule(e.g.Config.apm_replace_tags), which bottlecap consumes. bottlecap and the config crate must therefore resolve to a single libdatadog revision. Mixing revisions puts two incompatibleReplaceRuletypes in the dependency graph and fails to compile (E0308).No production source changes. Only
bottlecap/Cargo.toml(10 rev bumps) andbottlecap/Cargo.lock.Why now: the APMSVLS-469 error sampler consumes the new
datadog-agent-trace-samplercrate from serverless-components, which lives on a base that pinsa820699. Landing this bump first keeps that change focused on the sampler wiring and removes the long-standing bottlecap <-> serverless-components libdatadog drift.Testing
Verified on a clean worktree off
main(only the Cargo bump applied):cargo test --tests: all pass (lib +apm/appsec/logs/metricsintegration tests, including the fake-intake trace/stats protobuf roundtrips, so thelibdd-trace-protobufv3.0.2 wire format is compatible).cargo clippy --workspace --all-targets --features default: clean.--no-default-features --features fips) not run locally; relies on CI.🤖