feat(redis-ha): add EndpointSlices RBAC support#409
Merged
Conversation
Kubernetes v1.33 deprecates the Endpoints API in favor of EndpointSlices (discovery.k8s.io). Grant the redis-ha and haproxy Roles get access to endpointslices alongside the existing endpoints permission so the chart keeps working on newer clusters while remaining backward compatible. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #394.
Kubernetes v1.33 deprecates the
EndpointsAPI in favor ofEndpointSlices(discovery.k8s.io). Theredis-haandredis-ha-haproxyRoles currently only grantgeton the legacyendpointsresource. This PR adds an equivalentgetpermission onendpointslicesso the chart continues to work on newer clusters.The existing
endpointspermission is retained for backward compatibility — the Endpoints API is deprecated but still served on supported clusters, so this is a non-breaking, additive change.Changes
templates/redis-ha-role.yaml— adddiscovery.k8s.io/endpointslicesruletemplates/redis-haproxy-role.yaml— adddiscovery.k8s.io/endpointslicesruleChart.yaml— bump version4.38.0→4.39.0Testing
helm templaterenders both Roles with the newendpointslicesrule alongside the existingendpointsrule.🤖 Generated with Claude Code