Skip to content

[stable/redis-ha] Switch to standard labels#400

Open
chernetskyi wants to merge 2 commits into
DandyDeveloper:masterfrom
chernetskyi:standard-labels
Open

[stable/redis-ha] Switch to standard labels#400
chernetskyi wants to merge 2 commits into
DandyDeveloper:masterfrom
chernetskyi:standard-labels

Conversation

@chernetskyi

@chernetskyi chernetskyi commented May 4, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

Update label keys in redis-ha chart to follow common conventions:

grafana-agent, for example, already follows those.

Special notes for your reviewer:

Kept the same label order everywhere. Followed Helm's best practices to decide on the new label names:

Before After
app app.kubernetes.io/name
heritage app.kubernetes.io/managed-by
release app.kubernetes.io/instance
chart helm.sh/chart
component app.kubernetes.io/component

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

chernetskyi and others added 2 commits May 4, 2026 17:23
Signed-off-by: Volodymyr Chernetskyi <19735328+chernetskyi@users.noreply.github.com>
@DandyDeveloper

DandyDeveloper commented Jun 15, 2026

Copy link
Copy Markdown
Owner

@chernetskyi This is great, but this will break upgrades from users:

level=INFO msg="warning: skipped value for redis-ha.affinity: Not a table."
level=WARN msg="upgrade failed" name=redis error="server-side apply failed for object default/redis-redis-ha-haproxy apps/v1, Kind=Deployment: Deployment.apps \"redis-redis-ha-haproxy\" is invalid: spec.selector: Invalid value: {\"matchLabels\":{\"app.kubernetes.io/component\":\"haproxy\",\"app.kubernetes.io/instance\":\"redis\",\"app.kubernetes.io/name\":\"redis-ha-haproxy\"}}: field is immutable && server-side apply failed for object default/redis-redis-ha-server apps/v1, Kind=StatefulSet: StatefulSet.apps \"redis-redis-ha-server\" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'revisionHistoryLimit', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden"
Error: UPGRADE FAILED: server-side apply failed for object default/redis-redis-ha-haproxy apps/v1, Kind=Deployment: Deployment.apps "redis-redis-ha-haproxy" is invalid: spec.selector: Invalid value: {"matchLabels":{"app.kubernetes.io/component":"haproxy","app.kubernetes.io/instance":"redis","app.kubernetes.io/name":"redis-ha-haproxy"}}: field is immutable && server-side apply failed for object default/redis-redis-ha-server apps/v1, Kind=StatefulSet: StatefulSet.apps "redis-redis-ha-server" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'revisionHistoryLimit', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

It's a pretty significant break as people have to delete the STS and recreate which will bring down the clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants