fix(scripts): lokale Dev-Seed-Scripts von MSSQL auf PostgreSQL portieren#3982
Open
TaprootFreak wants to merge 1 commit into
Open
fix(scripts): lokale Dev-Seed-Scripts von MSSQL auf PostgreSQL portieren#3982TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Portiert die lokalen Dev-Seed-Scripts unter
scripts/von SQL Server (mssql-Treiber + T-SQL) auf PostgreSQL (pg) — konsistent mit der bereits portiertensetup.js(#3838).Betroffen:
scripts/testdata.jsscripts/kyc/kyc-testdata.jsscripts/kyc/kyc-storage.jsscripts/kyc/upload-kyc-files.js(DB-TeilgetKycCodes)scripts/kyc/upload-kyc-files.shbrauchte keine Änderung.Dialekt-Port (MSSQL → PostgreSQL)
mssql→pg(Clientstatt Pool, Port 1433 → 5432).input()-Params → positionale$1..$N;recordset→rowsOUTPUT INSERTED.id→RETURNING id;SELECT TOP 1→LIMIT 1;GETUTCDATE()→now() at time zone 'utc'"userDataId"…);[user]/[transaction]→"user"/"transaction"receive = truestatt= 1Mitgefixte vorbestehende Schema-Bugs
Damit die Scripts auf PostgreSQL tatsächlich durchlaufen (Ziel des Issues), wurden drei Schema-Inkompatibilitäten korrigiert, die bereits im MSSQL-Original vorhanden waren:
testdata.js:bank_tx-INSERT referenzierte die nicht existierende SpaltebankId→ entfernt; die NOT-NULL-SpalteaccountServiceReffehlte → ergänzt (unique uuid)kyc-testdata.js:kyc_log-INSERT liess die NOT-NULL-Spaltentype(STI-Discriminator) unduserDataIdaus → ergänztValidierung
Echter Lauf gegen eine frische PostgreSQL-DB (Schema + Referenzdaten):
testdata.js: vollständig durch — user_data 5, user 5, buy 4, bank_data 3, deposit 3, transaction 6, bank_tx 3, kyc_step 20, kyc_log 32kyc-testdata.js: vollständig durch — kyc_step/kyc_file/kyc_logkyc-storage.js: läuft (read-only JOIN)format:check/type-check/lintgrün;node --checkaller Dateien grünCloses #3965