fix: wirkungslose Mail-Prüfung in KYC-Benachrichtigungen#3939
Open
TaprootFreak wants to merge 1 commit into
Open
fix: wirkungslose Mail-Prüfung in KYC-Benachrichtigungen#3939TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
kycStepFailed und kycStepMissingData nutzten den Komma-Operator `(userData.mail, !DisabledProcess(...))`, wodurch die userData.mail-Prüfung verworfen wurde und nur das Prozess-Flag zählte. Dadurch wurde der Mailversand auch bei Nutzern ohne Mailadresse versucht. Korrigiert auf `userData.mail && !DisabledProcess(...)` (konsistent mit den übrigen Mail-Methoden).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
kycStepFailedundkycStepMissingDataprüften die Mailadresse mit dem Komma-Operator:if ((userData.mail, !DisabledProcess(Process.KYC_MAIL))). Der Komma-Operator verwirft den linken Ausdruck — dieuserData.mail-Prüfung war damit wirkungslos, und der Mailversand wurde auch für Nutzer ohne Mailadresse versucht.Fix
Beide Stellen auf
userData.mail && !DisabledProcess(Process.KYC_MAIL)korrigiert — konsistent mit den übrigen Mail-Methoden derselben Datei.Tests (lokal)
prettier ✅ · eslint ✅ · type-check ✅
Bestandsbug, unabhängig von anderen offenen PRs.