Release: develop -> main#3930
Merged
Merged
Conversation
#3927) * docs(lightning): explain why the TLS server-identity check is disabled * docs(lightning): tighten TLS bypass comment
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix(version): log when dist/version.txt cannot be read * fix(version): read commit once and log when dist/version.txt is unreadable
ArkadeClient polls for state (getTransaction/getVtxos) and never consumes the SDK's live contract events, but Wallet.create starts a background ContractWatcher anyway. On our Node 20 runtime the watcher has no global EventSource and the SDK's resubscribe path loops on a stale subscription id, flooding dfx-api logs on dev and prod (~1.6k errors/hr combined) with "EventSource is not defined" and "subscription not found". Stop the watcher right after wallet creation via the public ContractManager.dispose(). Best-effort and non-fatal — all wallet operations dfx-api actually uses (send/balance/vtxo/status) are unaffected.
* test(arkade): verifiziere Dispose des ContractWatcher nach Wallet-Erstellung * test(arkade): Disposal-Test race-fest + non-fatal-Pfad ergänzt - dediziertes Wallet/Mock je Test + Drain des eager-init Clients aus dem äusseren beforeEach, damit der geteilte Wallet.create-Spy die Call-Counts nicht doppelt zählt (unter verzögertem Wallet.create vorher flaky) - zweiter Test sichert den best-effort catch-Pfad: schlägt das Dispose fehl, läuft die Wallet-Erstellung trotzdem erfolgreich durch
TaprootFreak
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist