Release: develop -> main#3900
Merged
Merged
Conversation
…on (#3899) #3893 added a 'Host: <public hostname>' header to the LNBits requests so LNBits can build correct public LNURLs and pass its HTTPS check. But the HTTP client derives the TLS servername from that Host header, so Node began validating the node's self-signed cert against api.dfx.swiss. LND and LNBits are reached over the private IP on PRD and serve a cert whose SANs are localhost/lnd/<vm-dns>/<private-ip> — api.dfx.swiss is not among them, so every /v1/lnurlp/* (and lnurlw/lnurld) call failed with ERR_TLS_CERT_ALTNAME_INVALID (500). The cert is already pinned via the CA on the shared agent, which is the real identity guarantee for a private self-signed node; the SAN/hostname match is redundant and is exactly what the spoofed Host header poisons. Skip the hostname check (keep full chain verification) so the Host header stays intact for LNBits while TLS no longer depends on it. Host-agnostic, so it also holds once dfxprd reaches LNBits as 'lnd'.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
davidleomay
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist