feature(medcat): Allow filtering addons upoon model load#554
Open
mart-r wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #542 .
The target for this method (
CAT.load_addons) is trainer and it's (currently) only loading MetaCAT addons.So I've amended the method such that it is able to only load specfic addons if/when required.
PS:
There's a side effect of this where the addon type is now a class level attribute rather than an instance level one. But effectively that should be the case anyway.
NOTE:
The trainer changes themselves can't be included before the core lib changes are merged in and published because trainer runs against the latest (pinned) releases and not the current state of the core library.