Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: SkiaSharp.NativeAssets.Linux.NoDependencies dependency-version: 4.148.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/checkout-7 Bump actions/checkout from 6 to 7
…ompare/SkiaSharp.NativeAssets.Linux.NoDependencies-4.148.0 Bump SkiaSharp.NativeAssets.Linux.NoDependencies from 3.119.4 to 4.148.0
There was a problem hiding this comment.
Pull request overview
Modernizes the SkiaSharp.Compare solution by upgrading SkiaSharp and related dependencies, aligning the repo around .NET 10, updating CI to build/test with .NET 10, and adding a dev container configuration to simplify local development.
Changes:
- Upgraded SkiaSharp (and Linux native assets) to 4.148.0 and refreshed analyzer/test package versions.
- Dropped multi-targeting in the main library to target only
net10.0, and updated CI to build/test only with .NET 10. - Added a
.devcontainer/devcontainer.jsonto provide a consistent containerized development environment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SkiaSharpCompare/SkiaSharpCompare.csproj | Switches to net10-only targeting and bumps SkiaSharp/analyzer package versions. |
| SkiaSharpCompareTestNunit/SkiaSharpCompareTestNunit.csproj | Updates analyzer and test SDK package versions for the NUnit test project. |
| SkiaSharpCompare.Cli.Tests/SkiaSharpCompare.Cli.Tests.csproj | Updates NUnit/adapter/test SDK package versions for CLI test project. |
| .github/workflows/dotnet.yml | Updates CI actions and .NET SDK matrix; adjusts versioning and deploy-test triggering. |
| .devcontainer/devcontainer.json | Adds a standard .NET dev container configuration for onboarding/consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
95
to
97
| deployTest: | ||
| if: ${{ !startsWith(github.ref, 'refs/heads/release') }} | ||
| if: ${{ github.ref == 'refs/heads/main') }} | ||
| runs-on: ubuntu-latest |
Comment on lines
2
to
4
| <PropertyGroup> | ||
| <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks> | ||
| <TargetFrameworks>net10.0</TargetFrameworks> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> |
Comment on lines
15
to
17
| <PackageReference Include="nunit" Version="4.6.1" /> | ||
| <PackageReference Include="SonarAnalyzer.CSharp" Version="10.16.0.128591"> | ||
| <PackageReference Include="SonarAnalyzer.CSharp" Version="10.27.0.140913"> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> |
Replaced the legacy Visual Studio `.sln` file with a new `.slnx` solution definition, preserving the same projects and solution items in the new format. Also narrowed `SkiaSharpCompareTestNunit` target frameworks from `net8.0;net9.0;net10.0` to `net10.0` only, likely to align test builds with the current supported runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several important updates to the project, focusing on modernizing dependencies, improving CI workflows, and enhancing the development environment. The main changes include upgrading to .NET 10, updating key package dependencies, refining the GitHub Actions workflow for building and testing, and adding a dev container configuration for easier development setup.
Dependency and Target Framework Updates:
SkiaSharpCompare) now targets onlynet10.0, dropping support fornet8.0andnet9.0.SkiaSharp,SkiaSharp.NativeAssets.Linux.NoDependencies, andSonarAnalyzer.CSharpto their latest versions in both the main and test projects. [1] [2]NUnit,NUnit3TestAdapter, andMicrosoft.NET.Test.Sdk) to recent versions in bothSkiaSharpCompare.Cli.TestsandSkiaSharpCompareTestNunit. [1] [2]CI/CD Workflow Improvements:
actions/checkoutandactions/setup-dotnet, and to build/test only with .NET 10.0.x. [1] [2]mainbranch. [1] [2]Development Environment:
.devcontainer/devcontainer.jsonfile to provide a ready-to-use development container setup for C# (.NET) development, improving onboarding and consistency.