Add a pcap dump to the the mctpd process wrapper#156
Open
jk-ozlabs wants to merge 2 commits into
Open
Conversation
We're about to introduce a new option, so switch from manual sys.argv parsing. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
When debugging tests, it's helpful to view the sequence of MCTP commands between the emulated environment and mctpd. Add a small pcap writer, storing the packet data to a file. This is typically enabled by passing a file path to the MctpdWrapper constructor, but pcap output from the mctpenv main() can be enabled with a new --pcap argument too. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the test suite's mctpd process wrapper to provide a mock implementation of (remote) MCTP endpoints. Debugging test issues is much easier if we can analyse the MCTP communicatons between the
mctpdunder test, and the mock endpoint(s).This series adds a pcap writer to the mock MCTP socket implementation. This can either be enabled on the mctpenv
main()command-line, or via a temporary change to an invocation of the McptdWrapper constructor.We don't currently capture the netlink messaging, but that could be a nice future addition.