feat(client): Charm v2 migration and OSC 8 hyperlinks#104
Merged
Conversation
Upgrade Bubble Tea, Bubbles, and Lip Gloss to charm.land/*/v2 (tea.View, KeyPressMsg, bubbles setters). Wrapped URL segments emit OSC 8 hyperlinks with the full href on every fragment, addressing #103; manual click-to-open remains as fallback on terminals without OSC 8. Fix post-migration regressions: mouse wheel scroll routes to the active viewport (help, DB menu, chat, modals); help/DB overlays block chat typing indicators, URL clicks, and read-receipt flush; DB menu viewport resizes with the terminal. Admin panel and plugin store enable mouse mode for wheel scroll. Update ARCHITECTURE, CHANGELOG, TESTING, ROADMAP, agent skills, and tests.
Non-breaking hyphens used for wrap breakpoints were leaking into OSC 8 href attributes, producing Cod%E2%80%91e%E2%80%91Codes URLs on click. Normalize hrefs via normalizeURLHyphens before emitting hyperlinks.
Use a single Input background for the full-width composer, route Ctrl+J through textarea.Update for cursor tracking, and delegate arrow keys to the composer when multiline.
…rsor Paint full-width input background per composer line and only flatten empty bubbles buffer rows before typing. Multiline rows keep the virtual cursor and blink; placeholder buffer rows stay solid grey instead of alt-screen black.
Remove unused cursor style aliases left after v2 textinput styling, replace deprecated lipgloss Style.Copy with Faint chaining, and avoid string concatenation in strings.Builder.WriteString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bubbletea/bubbles/lipglossv2):tea.View,KeyPressMsg, setter APIs, and alt-screen background handling.textarea.Update, arrow keys in multiline).Closes #103
Test plan
go test ./...andcd plugin/sdk && go test ./...