Do not spam OK-emails when running as a cron-job.#17
Open
DanielGeerts wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running pakiti-client as a cron-job with email notification set-up, every OK-reply from the server would be printed to STDOUT, leading to an email for every single run and for every single machine. This is quite spammy.
This pull requests silences the STDOUT-printing if:
(a) STDOUT is not connected to a terminal. This is the case for cron-jobs. This check means that when running pakiti-client from a terminal, the printing behavior is unchanged, and the user gets feedback that the report was successfully received.
AND
(b) if the response from the server is NOT exactly "OK" (give or take trailing line-feeds). This check makes sure that if the server returns a warning followed by an OK, or any output without an OK, it is still printed, and thus cron will still report it.
People may be using these emails to verify that the pakiti-client cron-job ran. This can still be done on the pakiti-server. In fact, there's automatic highlighting build into its web-interface it specifically for that purpose.