feat: add integration test for account consolidation#241
Merged
Conversation
danielpeng1
commented
Jun 15, 2026
Comment on lines
-90
to
+93
| prebuildTx: unsignedBuild, | ||
| prebuildTx: { | ||
| ...unsignedBuild, | ||
| buildParams: { recipients: unsignedBuild.recipients ?? [] }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Fixing
handleConsolidateto restorebuildParams.recipientsso ETHverifyTransactionpasses during signing
needed as the integration test is running signing path e2e
danielpeng1
requested review from
Marzooqa,
pranavjain97,
pranishnepal and
vinhkhangtieu
| sendTx: 'sendTx.tbtc', | ||
| acceleratePrebuildTx: 'prebuildTx.accelerate.tbtc', | ||
| consolidatePrebuildTx: 'prebuildTx.consolidate.tbtc', | ||
| // consolidateAccountBuildTx omitted; UTXO coins use consolidateUnspents |
Contributor
There was a problem hiding this comment.
do we plan to add support for utxo (consolidateUnspents) as well? given that's the priority of the upcoming feature?
Contributor
Author
There was a problem hiding this comment.
yeah we already have an consolidateUnspents integ test so UTXO consolidation is already covered.
This just means that consolidateAccountBuildTx is omitted here because this consolidateAccountBuildTx (hteth) route doesn’t apply to UTXO coins
pranishnepal
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
consolidate.integ.test.tsfor hteth account-consolidate integration test coverage with EXTERNAL and LOCAL signing modesPOST /consolidateAccount/buildandconsolidateAccount.hteth.jsonfixturehandleConsolidateto restorebuildParams.recipientsso ETHverifyTransactionpasses during signingnpm run docker:test:integration)Ticket: WCN-911