Skip to content

Add QoS configuration to RosNodeParams#99

Open
rafal-gorecki wants to merge 8 commits into
BehaviorTree:humblefrom
rafal-gorecki:humble
Open

Add QoS configuration to RosNodeParams#99
rafal-gorecki wants to merge 8 commits into
BehaviorTree:humblefrom
rafal-gorecki:humble

Conversation

@rafal-gorecki

@rafal-gorecki rafal-gorecki commented Oct 21, 2024

Copy link
Copy Markdown

I really like this pkg and the way it was created. Bravo to the authors!

The only thing missing is the ability to set QoS for topics.
By the way, I also added the ability to change the qos_profile for services.

I found other solutions with similar themes, which may be updated if this PR passes:

@rafal-gorecki rafal-gorecki marked this pull request as draft October 21, 2024 16:32
@rafal-gorecki rafal-gorecki marked this pull request as ready for review October 21, 2024 16:45
@rafal-gorecki

Copy link
Copy Markdown
Author

Hello @tony-p @facontidavide,
Can I ask one of u guys for review?

@tony-p

tony-p commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

I'm not a maintainer so can't push this further. My first thought was why not define the qos in the node implementation as it will typically be constant for a particular message type, but on reflection I think adding to the params probably does make more sense.

@rafal-gorecki

Copy link
Copy Markdown
Author

Hi @facontidavide,
I see that you made the last change in this repo. Is it possible for you to check these changes?

@EricDavidWells

EricDavidWells commented Jul 10, 2025

Copy link
Copy Markdown

@rafal-gorecki Would love to get this merged, there is a small fix here to merge into this branch: https://github.com/rafal-gorecki/BehaviorTree.ROS2/pull/1/files.

@rafal-gorecki

rafal-gorecki commented Jul 11, 2025

Copy link
Copy Markdown
Author

I merge it, thanks @EricDavidWells

@shannonwarren

Copy link
Copy Markdown

any update on this? I'd like to set QoS in the node params instead of forking my own branch with this change.

@delihus

delihus commented Feb 9, 2026

Copy link
Copy Markdown

@facontidavide Is it possible to add thess changes to the upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants