-
Notifications
You must be signed in to change notification settings - Fork 4
enabled embeddings of raw turns, small other edits #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8f4d858
8748072
54279d2
2aa2ff8
954ff4e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,13 +45,18 @@ def __init__( | |
| from azure.cosmos.agent_memory._container_routing import ContainerKey | ||
| from azure.cosmos.agent_memory.aio.services.pipeline import AsyncPipelineService | ||
| from azure.cosmos.agent_memory.aio.store import AsyncMemoryStore | ||
| from azure.cosmos.agent_memory.thresholds import get_enable_turn_embeddings | ||
|
|
||
| containers = { | ||
| ContainerKey.TURNS: turns_container, | ||
| ContainerKey.MEMORIES: cosmos_container, | ||
| ContainerKey.SUMMARIES: summaries_container, | ||
| } | ||
| store = AsyncMemoryStore(containers=containers, embeddings_client=embeddings_client) | ||
| store = AsyncMemoryStore( | ||
| containers=containers, | ||
| embeddings_client=embeddings_client, | ||
| enable_turn_embeddings=get_enable_turn_embeddings(), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Turn embeddings only ever get created in one spot: when the client saves a turn (through store.add() / store.push() ). That's the only code that looks at this switch. Setting the enable_turn_embeddings doesn't do anything here, the value is picked from the client. we should remove this. |
||
| ) | ||
| pipeline = AsyncPipelineService(store, chat_client, embeddings_client, containers=containers) | ||
|
|
||
| self._pipeline = pipeline | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.