Skip to content

[PWGHF] Remove unsafe reserve in charm FemtoDream producers#16637

Merged
zhangbiao-phy merged 2 commits into
AliceO2Group:masterfrom
zhangbiao-phy:master
Jun 12, 2026
Merged

[PWGHF] Remove unsafe reserve in charm FemtoDream producers#16637
zhangbiao-phy merged 2 commits into
AliceO2Group:masterfrom
zhangbiao-phy:master

Conversation

@zhangbiao-phy

@zhangbiao-phy zhangbiao-phy commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

EDIT by @vkucera : Mitigates fatal caused by AliceO2Group/AliceO2#15450

@github-actions github-actions Bot added the pwghf PWG-HF label Jun 12, 2026
@github-actions github-actions Bot changed the title Remove unsafe reserve in charm FemtoDream producers [PWGHF] Remove unsafe reserve in charm FemtoDream producers Jun 12, 2026
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@vkucera

vkucera commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Hi @zhangbiao-phy , can you please briefly describe in the PR description the problem that this is solving?

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator Author

Hi @zhangbiao-phy , can you please briefly describe in the PR description the problem that this is solving?

Hi @vkucera, This PR fixes a runtime fatal error triggered by the stricter reserve() checks introduced recently from this PR: 473e398.

In these FemtoDream charm producers, the reconstructed charm candidate outputs were reserved with candidates.size() for a per-collision filtered candidate range. In some workflows this size can be zero while the range still yields a candidate during iteration, leading to errors such as:

Table 'FDHfCand2Prong': filled 1 rows after reserve(0)

Since the candidate range size is not a reliable upper bound for the number of rows filled in these tasks, this PR removes the unsafe reserve() calls for the reconstructed charm candidate output tables.

@zhangbiao-phy zhangbiao-phy merged commit c70c79b into AliceO2Group:master Jun 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants