Inconsistency: Survival event: status definition and KM y-axis label describe different events (Rmd:92, 410)

[clegoues]

The event indicator is defined as:

patchwork_analysis/patchwork_analysis.Rmd

Line 92 in 6ef8684

full_df$status = ifelse(full_df$time_minutes < 25, TRUE, FALSE)

and the KM plot of the survival function labels the y-axis:

patchwork_analysis/patchwork_analysis.Rmd

Line 410 in 6ef8684

ylab = "Probability of failing to create fix",

status is "finished/stopped before the 25-min cap", y axis says "created fix". But some people stopped before 25 minutes with incorrect fixes, right? Not sure if it's because you're only partway through, but didn't want the inconsistency to be missed down the line.

[kaianew]

Ah, yes. I am having difficulty deciding what to call this, actually. I changed the wording based on this issue being opened, but I am having trouble with possible names for the thing participants produce/decide they're done with.

"patch" -- overloaded with "patch suggestion"
"fix" -- implies they fixed it
"solution" -- kind of implies they fixed it
"response" -- gets rid of implication, but more ambiguous as to what the response is

Also, "failing to submit..." is overloaded with their assertion about whether or not they would submit a fix in an ecologically-valid environment. So...I went with "Probability of failing to produce response," for now...but it's not the most intuitive. WDYT, do you have any good ideas for what to call it? I'm happy to define a new term and use it consistently in the paper, too!