From 770f02293e40e50e3ee492dffb29a7297aee2f76 Mon Sep 17 00:00:00 2001 From: cbcrespo Date: Tue, 9 Jun 2026 13:37:23 +0100 Subject: [PATCH 1/2] Fix wrong reference on irradiance.reindl --- pvlib/irradiance.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index b38db534fe..a41f96ae6d 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -948,10 +948,12 @@ def reindl(surface_tilt, surface_azimuth, dhi, dni, ghi, dni_extra, References ---------- - .. [1] Reindl, D. T., Beckmann, W. A., Duffie, J. A., 1990a. Diffuse - fraction correlations. Solar Energy 45(1), 1-7. - :doi:`10.1016/0038-092X(90)90060-P` - .. [2] Reindl, D. T., Beckmann, W. A., Duffie, J. A., 1990b. Evaluation of + .. [1] Reindl, D. T., 1988. Estimating diffuse radiation on horizontal + surfaces and total radiation on tilted surfaces. M.Sc. thesis, + University of Wisconsin-Madison. Available from: + https://web.archive.org/web/20240709013622/https://minds.wisconsin.edu/bitstream/handle/1793/47852/0001.pdf + (Last accessed: 09/06/26) + .. [2] Reindl, D. T., Beckmann, W. A., Duffie, J. A., 1990. Evaluation of hourly tilted surface radiation models. Solar Energy 45(1), 9-17. :doi:`10.1016/0038-092X(90)90061-G` .. [3] Loutzenhiser P. G. et. al., 2007. Empirical validation of models to From 136ed6b138aa93c159ec6d80e56e6d5226ee3426 Mon Sep 17 00:00:00 2001 From: cbcrespo Date: Thu, 11 Jun 2026 12:37:54 +0100 Subject: [PATCH 2/2] Reindl IEEE references --- pvlib/irradiance.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index a41f96ae6d..6c39303b99 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -948,17 +948,18 @@ def reindl(surface_tilt, surface_azimuth, dhi, dni, ghi, dni_extra, References ---------- - .. [1] Reindl, D. T., 1988. Estimating diffuse radiation on horizontal - surfaces and total radiation on tilted surfaces. M.Sc. thesis, - University of Wisconsin-Madison. Available from: + .. [1] D. T. Reindl, "Estimating diffuse radiation on horizontal surfaces + and total radiation on tilted surfaces," M.S. thesis, University of + Wisconsin-Madison, Madison, WI, USA, 1988. Available: https://web.archive.org/web/20240709013622/https://minds.wisconsin.edu/bitstream/handle/1793/47852/0001.pdf - (Last accessed: 09/06/26) - .. [2] Reindl, D. T., Beckmann, W. A., Duffie, J. A., 1990. Evaluation of - hourly tilted surface radiation models. Solar Energy 45(1), 9-17. + .. [2] D. T. Reindl, W. A. Beckmann, and J. A. Duffie, "Evaluation of + hourly tilted surface radiation models," Solar Energy, vol. 45, + no. 1, pp. 9–17, 1990. :doi:`10.1016/0038-092X(90)90061-G` - .. [3] Loutzenhiser P. G. et. al., 2007. Empirical validation of models to + .. [3] P. G. Loutzenhiser, H. Manz, C. Felsmann, P. A. Strachan, + T. Frank, and G. M. Maxwell, "Empirical validation of models to compute solar irradiance on inclined surfaces for building energy - simulation. Solar Energy 81(2), 254-267 + simulation," Solar Energy, vol. 81, no. 2, pp. 254–267, 2007. :doi:`10.1016/j.solener.2006.03.009` '''