Skip to content

Add httpsoft/http-message (PSR-17 factories) support #241

Merged
dbu merged 4 commits into
php-http:1.xfrom
vjik:httpsoft-http-message
May 24, 2023
Merged

Add httpsoft/http-message (PSR-17 factories) support #241
dbu merged 4 commits into
php-http:1.xfrom
vjik:httpsoft-http-message

Conversation

@vjik

@vjik vjik commented May 14, 2023

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets -
Documentation php-http/documentation#309
License MIT

What's in this PR?

Add httpsoft/http-message (PSR-17 factories) support

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

@vjik vjik marked this pull request as ready for review May 14, 2023 18:36

@dbu dbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't know about httpsoft, thanks for the pull request.

is this implementation linked to yii or not really? if it has some default ties, you could define a "stickyness" rule to pick httpsoft when yii is present.
if you add it there, also add a test case to the installation check

@dbu

dbu commented May 22, 2023

Copy link
Copy Markdown
Contributor

the roave BC check step is broken, we unfortunately need to ignore it for now.

can you please rebase on the 1.x branch?

@vjik

vjik commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

is this implementation linked to yii or not really?

No. httpsoft is independent organization.

can you please rebase on the 1.x branch?

Done.

@dbu dbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nicolas-grekas any concerns or ok to merge?

btw, i noticed that you use the psr-7 integration tests. if you want you could add httpsoft to the that repository to increase visibility of httpsoft.

@dbu dbu requested a review from nicolas-grekas May 23, 2023 13:49
@vjik

vjik commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

btw, i noticed that you use the psr-7 integration tests. if you want you could add httpsoft to the that repository to increase visibility of httpsoft.

Done: php-http/psr7-integration-tests#73

Comment thread CHANGELOG.md Outdated
@dbu

dbu commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

released in https://github.com/php-http/discovery/releases/tag/1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants