From ef9208e03bcb272f1739c1c0b92cceb86a800259 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Tue, 30 Jun 2026 19:33:09 -0700 Subject: [PATCH 1/2] doc: recommend node-stress-single-test for flaky tests Add guidance to the collaborator guide and onboarding docs recommending node-stress-single-test when fixing flaky tests, so contributors verify stability under repeated runs. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> --- doc/contributing/collaborator-guide.md | 3 ++- onboarding.md | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 8f29042688ef6e..828625598da818 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -296,7 +296,8 @@ label to the pull request. * [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/) can run a group of tests over and over on a specific platform. Use it to check - that the tests are reliable. + that the tests are reliable. When fixing a flaky test, it is recommended to + run this job to verify the test remains stable under repeated runs. * [`node-test-commit-v8-linux`](https://ci.nodejs.org/job/node-test-commit-v8-linux/) runs the standard V8 tests. Run it when updating V8 in Node.js or floating new diff --git a/onboarding.md b/onboarding.md index 7d447163885adf..007d3e76787d09 100644 --- a/onboarding.md +++ b/onboarding.md @@ -286,7 +286,9 @@ needs to be pointed out separately during the onboarding. * If you are interested in helping to fix coverity reports consider requesting access to the projects coverity project as outlined in [static-analysis][]. * If you are interested in helping out with CI reliability, check out the - [reliability repository][] and [guide on how to deal with CI flakes][]. + [reliability repository][] and [guide on how to deal with CI flakes][]. When + fixing a flaky test, it is recommended to run [`node-stress-single-test`][] + to verify the test remains stable under repeated runs. [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md [Labels]: doc/contributing/collaborator-guide.md#labels @@ -296,6 +298,7 @@ needs to be pointed out separately during the onboarding. [`author-ready`]: doc/contributing/collaborator-guide.md#author-ready-pull-requests [`core-validate-commit`]: https://github.com/nodejs/core-validate-commit [`git-node`]: https://github.com/nodejs/node-core-utils/blob/HEAD/docs/git-node.md +[`node-stress-single-test`]: https://ci.nodejs.org/job/node-stress-single-test/ [`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/ [guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability [participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules From 0e538ecf3d32042015752676ffc3b4622348cdda Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Tue, 30 Jun 2026 23:56:55 -0700 Subject: [PATCH 2/2] fixup! doc: state "not flaky" in brackets Co-authored-by: Antoine du Hamel --- doc/contributing/collaborator-guide.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 828625598da818..c0777771be631e 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -296,8 +296,7 @@ label to the pull request. * [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/) can run a group of tests over and over on a specific platform. Use it to check - that the tests are reliable. When fixing a flaky test, it is recommended to - run this job to verify the test remains stable under repeated runs. + that the tests are reliable (i.e. not flaky). * [`node-test-commit-v8-linux`](https://ci.nodejs.org/job/node-test-commit-v8-linux/) runs the standard V8 tests. Run it when updating V8 in Node.js or floating new