From 0dfe24a8267d40b00c6bb8a3e761f559f2d7e237 Mon Sep 17 00:00:00 2001 From: Kailigithub Date: Fri, 5 Jun 2026 03:06:30 +0800 Subject: [PATCH] fix: reject unknown CLI args unless running in --reflect mode Previously, agentmain.py used parse_known_args() and silently ignored unknown flags. A typo like `--goal` (intended for a different launcher) was accepted without warning, causing the process to fall through into interactive mode and hang without dispatching any work. Now, unknown arguments are only permitted when --reflect is set, since extra key/value pairs are forwarded to the reflect script as parameters. Otherwise parser.error() prints usage and exits non-zero. Closes #566 --- agentmain.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/agentmain.py b/agentmain.py index 2f20f6deb..56cb1bd3f 100644 --- a/agentmain.py +++ b/agentmain.py @@ -206,7 +206,13 @@ def run(self): parser.add_argument('--nobg', action='store_true') parser.add_argument('--nolog', action='store_true') args, _unknown = parser.parse_known_args() - _extra_args = dict(zip([k.lstrip('-') for k in _unknown[::2]], _unknown[1::2])) if _unknown else {} + if _unknown and not args.reflect: + # Reject unknown CLI flags unless we are in --reflect mode, where + # extra key/value pairs are forwarded to the reflect script. + # Without this guard, typos like `--goal` silently fall through to + # interactive mode and the process looks alive without doing any work. + parser.error(f"unrecognized arguments: {' '.join(_unknown)}") + _reflect_args = dict(zip([k.lstrip('-') for k in _unknown[::2]], _unknown[1::2])) if _unknown else {} if (args.func or args.task) and not args.nobg: import subprocess, platform