docs: update clang/LLVM install instructions to v18#194
Open
simongdavies wants to merge 1 commit into
Open
Conversation
The README's setup instructions pinned clang/LLVM 16, but both the parent project's getting-started.md and CI (ci-setup-workflow) require and install clang 18. Bump the Ubuntu and Azure Linux install steps to 18 so the docs match the actual supported toolchain. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the clang/LLVM version in the README setup instructions from 16 → 18 (Ubuntu and Azure Linux sections).
Why
The README's install steps pinned clang/LLVM 16, but that's stale. The authoritative sources both require/install 18:
getting-started.mdusessudo ./llvm.sh 18.hyperlight-dev/ci-setup-workflow@v1.9.0) installs clang 18 (sudo ./llvm.sh 18 clang clang-tools-extra) and symlinks/usr/lib/llvm-18/bin/clang→/usr/bin/clang.Verified locally: pointing
/usr/bin/clangat llvm-18 resolves therquickjs-sysbindgenwint_t/__gnuc_va_listfailures that occur under clang 16/older, and the guest cross-compile tox86_64-hyperlight-nonethen succeeds.Scope
Pure version bump to keep the diff minimal and reviewable — no structural changes to the install steps.