Refactoring by template#170
Open
dukaev wants to merge 1 commit into
Open
Conversation
require "benchmark/ips"
def fast
end
def slow
end
Benchmark.ips do |x|
x.report("fast code description") { fast }
x.report("slow code description") { slow }
x.compare!
end
mateusdeap
reviewed
Oct 12, 2022
mateusdeap
left a comment
mateusdeap
left a comment
Member
There was a problem hiding this comment.
@dukaev I don't know if you're already on this, but I believe that if you just add Ashwini's suggestions to your PR, in the issue this solves, we can merge it.
Thanks for the good work!
Member
|
If not, that's fine. Just let me know and I can take it over. |
Author
|
@mateusdeap great. In a few days I will do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#169