Skip to content

Stopped hiding line numbers and relavite line numbers#20

Open
ar7casper wants to merge 1 commit into
augmentcode:mainfrom
ar7casper:feat-16/add-line-numbering-into-the-chat
Open

Stopped hiding line numbers and relavite line numbers#20
ar7casper wants to merge 1 commit into
augmentcode:mainfrom
ar7casper:feat-16/add-line-numbering-into-the-chat

Conversation

@ar7casper

Copy link
Copy Markdown

Referring to #16

@mgmonteleone mgmonteleone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent🛡️ with @mgmonteleone's authorization

Verdict: REQUEST CHANGES

I do not think we should take this change as-is. The deleted setlocal nonumber and setlocal norelativenumber lines are part of making the Augment chat buffer behave like a dedicated panel rather than a normal source buffer.

If these settings are removed, users with global number or relativenumber enabled will get line-number gutters in the chat panel. That adds visual noise, consumes horizontal space, and makes the markdown conversation UI less consistent. The chat panel already disables other editor affordances such as the sign column, cursorline, and spell checking for the same reason.

Please keep line numbers hidden in the chat panel. If there is a user need to show them, I would prefer a separate opt-in option rather than changing the default behavior for everyone.

@mgmonteleone mgmonteleone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining the current UI cleanup is preferred. Line numbers in the Markdown chat panel add visual noise without much benefit. If we want this to be configurable, it should be an opt-in g:augment_chat_show_numbers option rather than removing the suppression entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants