Remove realhostip references from the code

[vishesh92]

Description

This PR removes references for realhostip.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.10%. Comparing base (a0aafe2) to head (caebd0c).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
...va/com/cloud/storage/upload/UploadMonitorImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12856   +/-   ##
=========================================
  Coverage     18.10%   18.10%           
- Complexity    16746    16748    +2     
=========================================
  Files          6037     6037           
  Lines        542933   542926    -7     
  Branches      66487    66485    -2     
=========================================
+ Hits          98283    98292    +9     
+ Misses       433602   433586   -16     
  Partials      11048    11048           

Flag	Coverage Δ
uitests	3.51% <ø> (ø)
unittests	19.26% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR aims to remove legacy realhostip domain references across CloudStack (tests, SystemVM packaging/scripts, and management-server logic), and to clear stale configuration values during upgrade.

Changes:

• Replace *.realhostip.com/realhostip.com references in tests and comments with *.example.com/example.com.
• Rename/update SystemVM truststore/cert/key filenames from realhostip.* to systemvm.* and update related scripts/poms to reference the new names.
• Remove legacy “only realhostip supported” warnings and add an upgrade SQL to null out stale realhostip configuration values.

Reviewed changes

Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
utils/src/test/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtilTest.java	Updates test domain strings away from realhostip.
systemvm/pom.xml	Updates quickcloud trustStore filename to systemvm.keystore.
systemvm/patch-sysvms.sh	Updates keystore path used when importing JVM cacerts.
systemvm/debian/opt/cloud/bin/setup/bootstrap.sh	Updates keystore path used during systemvm bootstrap.
systemvm/agent/scripts/config_ssl.sh	Renames default cert/key/keystore filenames used for SSL setup.
systemvm/agent/scripts/_run.sh	Updates agent JVM trustStore filename to systemvm.keystore.
systemvm/agent/certs/systemvm.keystore	Adds/renames keystore artifact used by SystemVM components.
systemvm/agent/certs/systemvm.key	Adds/renames private key artifact used by SystemVM SSL setup.
systemvm/agent/certs/systemvm.csr	Adds/renames CSR artifact.
systemvm/agent/certs/systemvm.crt	Adds/renames certificate artifact.
services/secondary-storage/server/pom.xml	Updates trustStore filename to systemvm.keystore.
services/console-proxy/server/pom.xml	Updates excluded CSR filename to systemvm.csr.
server/src/test/java/com/cloud/keystore/KeystoreTest.java	Updates hard-coded test domain strings away from realhostip.
server/src/main/java/com/cloud/storage/upload/UploadMonitorImpl.java	Removes legacy realhostip fallback/logic and adjusts URL generation behavior.
server/src/main/java/com/cloud/storage/download/DownloadMonitorImpl.java	Removes legacy warning tied to realhostip domain/cert expectations.
server/src/main/java/com/cloud/server/ConfigurationServerImpl.java	Clears the legacy secstorage.secure.copy.cert default value.
engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql	Clears stale realhostip configuration values during upgrade.
.pre-commit-config.yaml	Updates pre-commit allowlist to match the renamed private key filename.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17193

[vishesh92]

@blueorangutan test keepEnv

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

overall lgtm

my only concern is, will live-patch of system vms (created before upgrade) work ?

[vishesh92]

overall lgtm

my only concern is, will live-patch of system vms (created before upgrade) work ?

Yes. I have made the changes but didn't test them.
We will probably need to have some additional release notes for this or make some changes in the PR for backward compatibility.

[blueorangutan]

[SF] Trillian test result (tid-15691)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51149 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t15691-kvm-ol8.zip
Smoke tests completed. 148 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.19	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	5.03	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.16	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.17	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	32.21	test_snapshots.py
test_01_snapshot_usage	Error	25.95	test_usage.py
test_01_vpn_usage	Error	1.17	test_usage.py

[vishesh92]

@blueorangutan package

I have done some testing. The fresh build is working fine.

For upgrades (followed docs) & systemVM patching I followed these steps:

1. Stop MS
2. Upgrade MS
3. Stop agents
4. Upgrade agents
5. Start MS
6. Test console proxy by opening console
7. Patch console proxy. Agent was in Up state after patching. The version was also updated.
8. Test console proxy by opening console

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled withI have done some testing. The fresh build is working fine.

For upgrades (followed docs) & systemVM patching I followed these steps:

1. Stop MS
2. Upgrade MS
3. Stop agents
4. Upgrade agents
5. Start MS
6. Test console proxy by opening console
7. Patch console proxy. Agent was in Up state after patching. The version was also updated.
8. Test console proxy by opening console SystemVM template(s). I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17230

[vishesh92]

@blueorangutan test matrix

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-15720)

[blueorangutan]

[SF] Trillian Build Failed (tid-15723)

[blueorangutan]

[SF] Trillian test result (tid-15719)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54483 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t15719-kvm-ol8.zip
Smoke tests completed. 147 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.17	test_list_ids_parameter.py
test_01_deployVMInSharedNetwork	Failure	383.12	test_network.py
test_01_snapshot_root_disk	Error	2.99	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.07	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.07	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	35.38	test_snapshots.py
test_01_snapshot_usage	Error	22.78	test_usage.py
test_01_vpn_usage	Error	1.13	test_usage.py

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@vishesh92 can you have a look :( ?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18011

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[blueorangutan]

[SF] Trillian test result (tid-16176)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 47190 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t16176-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@weizhouapache @vishesh92 any extra testing needed here?

[vishesh92]

@weizhouapache @vishesh92 any extra testing needed here?

I need to check if the upgrade works successfully with vmware. We can merge after that.

[vladimirpetrov]

LGTM based on manual testing.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[weizhouapache]

@vishesh92
could you please fix the conflicts ?

this is ready for merge

[vishesh92]

@vishesh92 could you please fix the conflicts ?

this is ready for merge

Resolved.

[vishesh92]

@vishesh92 could you please fix the conflicts ?
this is ready for merge

Resolved.

I have tested with vmware and it's working as expected.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18181