From 5eb06c8a8a490ae2cb4f8bf47e47e0ddbbda6473 Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Thu, 23 Jan 2025 16:18:12 -0800 Subject: [PATCH] REGRESSION(287403@main): Unable to link libjavascriptcoregtk: undefined reference to `ipint_extern_prepare_call_ref' https://bugs.webkit.org/show_bug.cgi?id=286433 Reviewed by Yusuke Suzuki. The names of these macros are a little confusing, but I gather that HIDDEN is supposed to be used for declarations in header files. * Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h: Canonical link: https://commits.webkit.org/289320@main --- Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h b/Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h index d9d51cf03f0c2..9d4c249d8cb10 100644 --- a/Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h +++ b/Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h @@ -111,7 +111,7 @@ WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(call_indirect, CallFrame* callFrame, Wasm::Fun // We can't use FunctionSpaceIndex here since ARMv7 ABI always passes structs on th stack... WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(prepare_call, unsigned functionSpaceIndex, EncodedJSValue* callee); WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(prepare_call_indirect, CallFrame* callFrame, Wasm::FunctionSpaceIndex* functionIndex, CallIndirectMetadata* call); -WASM_IPINT_EXTERN_CPP_DECL(prepare_call_ref, CallFrame*, Wasm::TypeIndex, IPIntStackEntry*); +WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(prepare_call_ref, CallFrame*, Wasm::TypeIndex, IPIntStackEntry*); WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(set_global_ref, uint32_t globalIndex, JSValue value); WASM_IPINT_EXTERN_CPP_HIDDEN_DECL(get_global_64, unsigned);